Repository navigation
Keystore / Seed Phrase field enhancements #36
Description
Activity
- changed the title
[-]style: After I’ve picked a file (or dropped one into the field) I want the “Seed Phrase” field to go away since it will never be needed in that case, and the user shouldn’t feel like he’s leaving something blank. If I’ve picked a “backup” then the alias should go away also, since it is always required when making a new wallet (is it enforced when backing up?). If so, it would be populated after hitting “Add wallet” and the user can always edit it, but I don’t think we should help them get in the habit of redefining the alias here in the “Existing Wallet” import. An alternative to hiding the alias field would be to name it automatically by the file name, but that might require more coding than it’s worth, and it might clash with the name in the keystore file, so I’m not sure that’s a good option.[/-][+]Keystore OR Seed Phrase field enhancements[/+]on Feb 10, 2024 @riongull per this commit 5afad8a, there should be enhancements to the original stage 1 functionality.
Keystore drop zone or seed phrase field should get disabled based on interaction with the opposing field.
Alias has updates for Generate & Import to have better descriptions & a title set that gets displayed when the forms pattern is invalid, and details how to make a valid alias.
Please check https://fix-stage-1-qa.wallet.dashincubator.dev/ and see if that matches your expectations.
- changed the title
[-]Keystore OR Seed Phrase field enhancements[/-][+]Keystore / Seed Phrase field enhancements[/+]on Feb 10, 2024 Disabling the unnecessary fields is a nice improvement. I think I'm still inclined to disable the populated alias field as well, but maybe let's have @coolaj86 and/or others test it to see what they have to say.
A couple issues:
- There's no way to unselect an already selected file
- The file upload field doesn't highlight when tabbing. it works, just no visual feedback.
- added a commit that references this issue
on Feb 11, 2024 - added a commit that references this issue
on Feb 14, 2024
style: After I’ve picked a file (or dropped one into the field) I want the “Seed Phrase” field to go away since it will never be needed in that case, and the user shouldn’t feel like he’s leaving something blank.
If I’ve picked a “backup” then the alias should go away also, since it is always required when making a new wallet (is it enforced when backing up?).
If so, it would be populated after hitting “Add wallet” and the user can always edit it, but I don’t think we should help them get in the habit of redefining the alias here in the “Existing Wallet” import.
An alternative to hiding the alias field would be to name it automatically by the file name, but that might require more coding than it’s worth, and it might clash with the name in the keystore file, so I’m not sure that’s a good option.