feat: supported display all types of broadway's names #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 7, 2021
josevalim
reviewed
Sep 7, 2021
| String.to_existing_atom(nav) | ||
| rescue | ||
| ArgumentError -> nil | ||
| nav && Enum.find(pipelines, fn name -> inspect(name) == nav end) |
There was a problem hiding this comment.
If it is not an atom, what is the other name? Is it a PID or is it a {:via, ...} tuple?
There was a problem hiding this comment.
Show on dashboard like this:
# atom
iex> Demo.Pipeline |> inspect()
"Demo.Pipeline"
# tuple
iex> {:via, Registry, {MyRegistry, :atom}} |> inspect()
"{:via, Registry, {MyRegistry, :atom}}"
# pid
iex> self() |> inspect()
"#PID<0.3204.0>"Show on url like this:
# atom
iex> Demo.Pipeline |> inspect() |> URI.encode_www_form()
"Demo.Pipeline"
# tuple
iex> {:via, Registry, {MyRegistry, :atom}} |> inspect() |> URI.encode_www_form()
"%7B%3Avia%2C+Registry%2C+%7BMyRegistry%2C+%3Aatom%7D%7D"
# pid
iex> self() |> inspect() |> URI.encode_www_form()
"%23PID%3C0.3204.0%3E"
philss
suggested changes
Sep 7, 2021
mix.lock
Outdated
| "phoenix_pubsub": {:hex, :phoenix_pubsub, "2.0.0", "a1ae76717bb168cdeb10ec9d92d1480fec99e3080f011402c0a2d68d47395ffb", [:mix], [], "hexpm", "c52d948c4f261577b9c6fa804be91884b381a7f8f18450c5045975435350f771"}, | ||
| "plug": {:hex, :plug, "1.12.1", "645678c800601d8d9f27ad1aebba1fdb9ce5b2623ddb961a074da0b96c35187d", [:mix], [{:mime, "~> 1.0 or ~> 2.0", [hex: :mime, repo: "hexpm", optional: false]}, {:plug_crypto, "~> 1.1.1 or ~> 1.2", [hex: :plug_crypto, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4.3 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "d57e799a777bc20494b784966dc5fbda91eb4a09f571f76545b72a634ce0d30b"}, | ||
| "plug_cowboy": {:hex, :plug_cowboy, "2.5.1", "7cc96ff645158a94cf3ec9744464414f02287f832d6847079adfe0b58761cbd0", [:mix], [{:cowboy, "~> 2.7", [hex: :cowboy, repo: "hexpm", optional: false]}, {:cowboy_telemetry, "~> 0.3", [hex: :cowboy_telemetry, repo: "hexpm", optional: false]}, {:plug, "~> 1.7", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "107d0a5865fa92bcb48e631cc0729ae9ccfa0a9f9a1bd8f01acb513abf1c2d64"}, | ||
| "plug_cowboy": {:hex, :plug_cowboy, "2.3.0", "149a50e05cb73c12aad6506a371cd75750c0b19a32f81866e1a323dda9e0e99d", [:mix], [{:cowboy, "~> 2.7", [hex: :cowboy, repo: "hexpm", optional: false]}, {:plug, "~> 1.7", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "bc595a1870cef13f9c1e03df56d96804db7f702175e4ccacdb8fc75c02a7b97e"}, |
There was a problem hiding this comment.
This is not a problem, but do you know why the downgrade of plug_cowboy?
There was a problem hiding this comment.
It is something related to telemetry and hex, I can take a look at it later.
|
@feng19 to fix the CI issue you need to run |
If I upgrade plug_cowboy to Upgrade it? |
@feng19 yes, I think it's fine to upgrade. 👍 It's only used in development. |
|
@feng19 thank you! 💜 |
|
❤️❤️❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate on #12