Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace spray json with zio-json for FileMetadataSipiResponse #2941

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Nov 16, 2023

Pull Request Checklist

Task Description/Number

Spray json is able to parse 42.0 as an Int, zio-json is more strict fails, see also zio/zio-json#1049. Hence, we have to add a custom decoder for Int.

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Does this PR change client-test-data?

  • Yes

@seakayone seakayone changed the title refactor: Replace spray json with zio-json refactor: Replace spray json with zio-json for FileMetadataSipiResponse Nov 16, 2023
@seakayone seakayone force-pushed the refactor/replace-spray-json-with-zio-json branch from c1939f9 to b7a7a93 Compare November 16, 2023 13:25
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (ff9df5f) 11.63% compared to head (f31e000) 11.64%.
Report is 7 commits behind head on main.

Files Patch % Lines
...s/v2/responder/valuemessages/ValueMessagesV2.scala 0.00% 22 Missing ⚠️
.../org/knora/webapi/store/iiif/api/SipiService.scala 0.00% 9 Missing ⚠️
...knora/webapi/store/iiif/impl/SipiServiceLive.scala 0.00% 5 Missing ⚠️
...ra/webapi/responders/v2/ResourcesResponderV2.scala 0.00% 4 Missing ⚠️
...c/main/scala/org/knora/webapi/core/AppServer.scala 0.00% 2 Missing ⚠️
...vsearch/prequery/GravsearchQueryOptimisation.scala 0.00% 2 Missing ⚠️
...ora/webapi/responders/admin/SipiResponderADM.scala 0.00% 2 Missing ⚠️
...org/knora/webapi/routing/admin/FilesRouteADM.scala 0.00% 2 Missing ⚠️
...la/org/knora/webapi/routing/v2/SearchRouteV2.scala 0.00% 2 Missing ⚠️
.../webapi/store/iiif/IIIFRequestMessageHandler.scala 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2941   +/-   ##
=======================================
  Coverage   11.63%   11.64%           
=======================================
  Files         247      246    -1     
  Lines       22922    22887   -35     
=======================================
- Hits         2668     2666    -2     
+ Misses      20254    20221   -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seakayone seakayone marked this pull request as ready for review November 16, 2023 13:48
@seakayone seakayone assigned seakayone and unassigned mpro7 and BalduinLandolt Nov 16, 2023
@seakayone seakayone merged commit 20090dc into main Nov 16, 2023
14 checks passed
@seakayone seakayone deleted the refactor/replace-spray-json-with-zio-json branch November 16, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants