Implement Replace::Replace properly for aarch64
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a separate implementation for aarch64 which boils down to
ldr x17, =0x1122334455667788
br x17
The `x17` register is used as it's allowed to be modified during
function call and doesn't require saving. Old approach under `SOME_ARM`
ifdef that doesn't require changing any registers isn't possible since
the `pc` register is no longer directly accessible.
Tested with qemu-aarch64 user mode emulation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a separate implementation for aarch64 which boils down to
The
x17register is used as it's allowed to be modified during function call and doesn't require saving. Old approach underSOME_ARMifdef that doesn't require changing any registers isn't possible since thepcregister is no longer directly accessible.Tested with qemu-aarch64 user mode emulation. I've also only tested it with
cpp11branch, but opening the PR againstmaster; do tell if additional PR againstcpp11will be required or whether you'll merge it there yourself.Potentially fixes #73, #57. CC @rzr for review.