Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI bug fixes, improvements, and color #315

Merged
merged 13 commits into from
Jul 31, 2017
Merged

CLI bug fixes, improvements, and color #315

merged 13 commits into from
Jul 31, 2017

Conversation

m4b
Copy link
Collaborator

@m4b m4b commented Jul 30, 2017

WIP

  1. Adds color 😻 to asm in CLI
    screenshot from 2017-07-30 13-58-45

  2. Moves the CLI display logic to CLI module

  3. Fixes longstanding bug incorrectly resolving call to internal, resolved functions, and now correctly displays name, e.g.:
    screenshot from 2017-07-30 14-04-11

  4. Correctly resolves multiple function aliases, e.g., printf, _IO_printf in libc

  5. Adds a new 2x faster pipeline which updates the program object automatically, and uses rayon for parallelism when no UI thread will be present (so CLI uses it)

  6. Adds a function iterator to program for ergonomics

  7. some touchup and love to the program object

  8. Add region() method to project, so clients don't need to import graph-algos to use project

@m4b m4b force-pushed the m4b/cli_color branch from 535afd5 to 740d5b5 Compare July 30, 2017 21:06
@m4b
Copy link
Collaborator Author

m4b commented Jul 30, 2017

NOTE: we should switch eventually to either term or termcolor to be more friendly (e.g., not print garbage) to window machines, as well as when piping to a file

@flanfly
Copy link
Member

flanfly commented Jul 30, 2017

Wow, fancy! 😍

(e.g., not print garbage) to window machines, as well as when piping to a file

We can always fix things Later™️

@m4b
Copy link
Collaborator Author

m4b commented Jul 30, 2017

It's not like people use windows that much anyway ;)

I actually already find syntax highlighting for asm output indispensable. Helped find and fix call function bug, as well as highlighting the semantic differences, e.g. je in x86 as well as how leaq is treated

@m4b m4b requested a review from flanfly July 31, 2017 08:11
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 59.812% when pulling faec0ef on m4b/cli_color into c738b31 on master.

@flanfly flanfly merged commit 5414f78 into master Jul 31, 2017
@flanfly
Copy link
Member

flanfly commented Jul 31, 2017

👍 Amazing work as usual

@sphinxc0re sphinxc0re deleted the m4b/cli_color branch July 31, 2017 09:05
@sphinxc0re
Copy link
Contributor

@m4b does the highlighting work under Windows as well?

@m4b
Copy link
Collaborator Author

m4b commented Jul 31, 2017

No :/ need to add term or termcolor crate for better cross platform printing. shouldn't be too hard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants