-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI bug fixes, improvements, and color #315
Conversation
…y pipeline, which also fills up and returns program instance
NOTE: we should switch eventually to either |
Wow, fancy! 😍
We can always fix things Later™️ |
It's not like people use windows that much anyway ;) I actually already find syntax highlighting for asm output indispensable. Helped find and fix call function bug, as well as highlighting the semantic differences, e.g. |
👍 Amazing work as usual |
@m4b does the highlighting work under Windows as well? |
No :/ need to add term or termcolor crate for better cross platform printing. shouldn't be too hard |
WIP
Adds color 😻 to asm in CLI
Moves the CLI display logic to CLI module
Fixes longstanding bug incorrectly resolving
call
to internal, resolved functions, and now correctly displays name, e.g.:Correctly resolves multiple function aliases, e.g.,
printf
,_IO_printf
in libcAdds a new 2x faster pipeline which updates the
program
object automatically, and uses rayon for parallelism when no UI thread will be present (so CLI uses it)Adds a function iterator to program for ergonomics
some touchup and love to the program object
Add
region()
method to project, so clients don't need to import graph-algos to use project