Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add additional restrictions when using batching #72

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

darwin67
Copy link
Owner

cancellation and rate limit can't be used with event batching, so make sure to add those validation as well.

@darwin67 darwin67 marked this pull request as ready for review November 27, 2023 07:12
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (939d559) 72.67% compared to head (0452656) 73.58%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   72.67%   73.58%   +0.91%     
==========================================
  Files          20       20              
  Lines         377      390      +13     
==========================================
+ Hits          274      287      +13     
  Misses        103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darwin67 darwin67 merged commit 54e4755 into main Nov 27, 2023
@darwin67 darwin67 deleted the fix/batch-checks branch November 27, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant