Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13 #158

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Add support for Python 3.13 #158

merged 1 commit into from
Oct 9, 2024

Conversation

jameshilliard
Copy link
Contributor

@jameshilliard jameshilliard commented Oct 9, 2024

Fixes #157.

@jameshilliard jameshilliard force-pushed the python313 branch 4 times, most recently from e2baf3e to 3569de6 Compare October 9, 2024 19:46
@darvid
Copy link
Owner

darvid commented Oct 9, 2024

thanks for the quick PR!

i'm guessing the lint workflow file is being run off of main which is the reason it's not picking up the version update. would you mind making a separate PR to update the CI action versions, and I'll go ahead and approve that? then I'll disable the main branch protection momentarily to test the build before merging this.

@jameshilliard
Copy link
Contributor Author

would you mind making a separate PR to update the CI action versions, and I'll go ahead and approve that?

Split those changes out into #159.

@jameshilliard
Copy link
Contributor Author

Yep, looks like that fixed it, I rebased this PR as well.

@darvid darvid merged commit 684b308 into darvid:main Oct 9, 2024
1 check passed
@darvid
Copy link
Owner

darvid commented Oct 9, 2024

not sure why i can't trigger a workflow off this branch despite workflow_dispatch allowed in the GH actions for the wheels workflow, so gonna just merge and pray it works :) will have time to troubleshoot issues/cut a release (if the automated release action fails) later tonight

@jameshilliard jameshilliard deleted the python313 branch October 9, 2024 20:16
@jameshilliard
Copy link
Contributor Author

not sure why i can't trigger a workflow off this branch despite workflow_dispatch allowed in the GH actions for the wheels workflow

Maybe related to these conditionals github.repository == 'darvid/python-hyperscan' since the PR is coming from a different repo?

@jameshilliard
Copy link
Contributor Author

will have time to troubleshoot issues/cut a release (if the automated release action fails) later tonight

Get a chance to look at that?

@darvid
Copy link
Owner

darvid commented Oct 12, 2024

standby sorry, CI issues with the release process

had to fix a bunch of macos build issues which was blocking the release

@darvid
Copy link
Owner

darvid commented Oct 12, 2024

Released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

please add wheels for python 3.13
2 participants