Add an integration test for serve #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
changed the title
|
@nshahan – fixed windows builds and now using SIGINT. PTAL |
nshahan
approved these changes
Apr 11, 2018
|
|
||
| group('should serve with valid configuration', () { | ||
| for (var withDDC in [true, false]) { | ||
| test(withDDC ? 'DDC' : 'dart2js', () async { |
There was a problem hiding this comment.
nit: I'd argue that this kind of logic will make it harder to know where to look if one of these tests starts failing.
|
Ack. But this is a non-trivial amount of code to duplicate.
Could make it a method, but not sure that's much better.
…On Wed, Apr 11, 2018 at 9:47 AM Nicholas Shahan ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In webdev/test/e2e_test.dart
<#37 (comment)>:
> }
}
});
}
});
+
+ group('should serve with valid configuration', () {
+ for (var withDDC in [true, false]) {
+ test(withDDC ? 'DDC' : 'dart2js', () async {
nit: I'd argue that this kind of logic will make it harder to know where
to look if one of these tests starts failing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCinNJra8mw7rQq0iiAAWDoHyvKsIKks5tnjOQgaJpZM4TQIYM>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on #35 to land