Skip to content

Pass the remaining args when running serve #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2018
Merged

Pass the remaining args when running serve #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3f0c39
Pass the remaining args when running serve
nshahan Apr 10, 2018
10eddfe
Merge branch 'master' into serverDir
kevmoo Apr 11, 2018
a241af7
update version and changelog
kevmoo Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions webdev/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.1.5

- Pass the arguments supporting `directory:port` for the `serve` command.

## 0.1.4

- Require and use features from `build_runner` 0.8.2.
Expand Down
3 changes: 3 additions & 0 deletions webdev/lib/src/command/serve_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ class ServeCommand extends CommandBase {
arguments.add('--log-requests');
}

// The remaining arguments should be interpreted as [<directory>[:<port>]].
arguments.addAll(argResults.rest);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version and add a -dev, and add a note in the changelog

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nshahan – I took care of the rebase and changelog. Taking a look at an integration test now...


return arguments;
}

Expand Down
2 changes: 1 addition & 1 deletion webdev/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: webdev
version: 0.1.4
version: 0.1.5-dev
author: Dart Team <misc@dartlang.org>
homepage: https://github.com/dart-lang/webdev
description: >-
Expand Down