Test cleanup, prepare for v0.1.4 #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimize chance of a timeout
natebosch
reviewed
Apr 9, 2018
| var expectedItems = <Object>['[INFO] Succeeded']; | ||
| if (!withDDC) { | ||
| expectedItems.add(anyOf( | ||
| contains('with 0 outputs'), contains('Running dart2js with'))); |
There was a problem hiding this comment.
Could the "with 0 outputs" case indicate a problem?
Also the "Running dart2js with" case could be broken for subsequent builds if I implement a change in build_web_compilers... it would be breaking there though so I guess we could update this test if that happens.
There was a problem hiding this comment.
Could the "with 0 outputs" case indicate a problem?
Maybe, although I validate dart2js output below. It's mostly for my dev machine where the output may already exist.
it would be breaking there though so I guess we could update this test if that happens.
Yup
natebosch
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.