Support custom sdkRoot for frontend server executable paths#2777
Open
nielsenko wants to merge 1 commit intodart-lang:mainfrom
Open
Support custom sdkRoot for frontend server executable paths#2777nielsenko wants to merge 1 commit intodart-lang:mainfrom
nielsenko wants to merge 1 commit intodart-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sdkRootparameter was already accepted but wasn't actually used when resolving executable and snapshot paths. All paths were unconditionally derived fromPlatform.resolvedExecutableviasdkDir, ignoring any customsdkRootpassed by the caller.This fix wires
sdkRootthrough to the path helpers so that when a custom SDK root is provided, all resolved paths (dart executable, AOT runtime, AOT snapshot, and AppJIT snapshot) use it instead of the host process's SDK location.Changes:
_dartAotRuntimePath,_feServerAotSnapshotPath, and_feServerAppJitSnapshotPathfrom staticfinalfields to functions that accept an optionalsdkRoot, falling back tosdkDirwhen not provided._dartExecutable(sdkRoot)helper that returns the custom SDK'sbin/dartwhensdkRootis set, otherwisePlatform.resolvedExecutable.Process.startcalls to use the resolved paths.Fixes: #2767
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.