Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to use dart pub instead of pub #2195

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Update README.md to use dart pub instead of pub #2195

merged 2 commits into from
Sep 5, 2023

Conversation

julemand101
Copy link
Contributor

@julemand101 julemand101 commented Aug 11, 2023

The pub command no longer exist and users are therefore required to use dart pub instead for installation.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

The `pub` command no longer exist and users are therefore required to use `dart pub` instead for installation.
@elliette
Copy link
Contributor

Thanks! The failing release reminder test should be fixed by merging this branch with master

@julemand101
Copy link
Contributor Author

Hope I done the pull correctly and everything is okay now.

@elliette elliette self-requested a review August 22, 2023 18:41
@elliette
Copy link
Contributor

Thank you! LGTM

@auto-submit
Copy link

auto-submit bot commented Aug 23, 2023

auto label is removed for dart-lang/webdev/2195, due to This PR has not met approval requirements for merging. You are not a member of dart-team and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit label Aug 23, 2023
@julemand101
Copy link
Contributor Author

@elliette Do you know why this pull-request have yet to be merged? It does not really have any kind of deadline but I just find it weird it just stays in this state like it is waiting for something?

@elliette
Copy link
Contributor

elliette commented Sep 5, 2023

auto label is removed for dart-lang/webdev/2195, due to This PR has not met approval requirements for merging. You are not a member of dart-team and need 1 more review(s) in order to merge this PR.

You will need to merge it manually (with the Squash and merge button) - if you don't see it, I can merge it for you.

@julemand101
Copy link
Contributor Author

Well, I don't have that button so you are allowed to do so for me :)
Guess it is because I am not part of the project?

@elliette elliette merged commit 9487a45 into dart-lang:master Sep 5, 2023
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants