Create test_common package #1945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annagrin
commented
Feb 8, 2023
annagrin
commented
Feb 8, 2023
annagrin
commented
Feb 8, 2023
13 tasks
annagrin
commented
Feb 10, 2023
annagrin
force-pushed
the
annagrin/test-common
branch
from
036899b to
e781731
Compare
annagrin
commented
Feb 14, 2023
elliette
reviewed
Feb 14, 2023
| @@ -9,14 +9,13 @@ import 'dart:convert'; | |||
| import 'dart:io'; | |||
|
|
|||
| import 'package:dwds/expression_compiler.dart'; | |||
| import 'package:dwds/sdk_configuration.dart'; | |||
There was a problem hiding this comment.
Should this be test_sdk_configuration?
There was a problem hiding this comment.
This one should not need any extra assets, so it is actually good to test it with the current SDK layout. I'll add a comment.
There was a problem hiding this comment.
Oh wait it is currently running with weak null safety! Will update (so then the statement that it does not need any extra assets will be true:)
elliette
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create test_common package:
TestSdkLayoutwith test-only sdk layout paths totest_common.SdkAssetGenerator, logging totest_common.dwds/test/fixtures/logging.darttotest_common.test_commontests.test_common.frontend_server_commonuseTestSdkLayoutinstead of hard coded layout strings.Note: this change allows us to enable weak null safety tests for webdev (to be addressed in a separate PR).
Towards: #1878
Closes: #1892