-
Notifications
You must be signed in to change notification settings - Fork 82
Prepare for dart 3.0 alpha changes: Handle SDK layout update #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
annagrin
merged 3 commits into
dart-lang:master
from
annagrin:annagrin/rename-assets-only
Jan 24, 2023
Merged
Prepare for dart 3.0 alpha changes: Handle SDK layout update #1907
annagrin
merged 3 commits into
dart-lang:master
from
annagrin:annagrin/rename-assets-only
Jan 24, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
- change min SDK constraint to 3.0.0-134.0.dev - update build_web_compilers to ^4.0.0 - update build_runner to ^2.4.0 - update SDK paths in code - remove CI testing on stable and add testing on main
4e252f9
to
8922637
Compare
elliette
reviewed
Jan 24, 2023
elliette
reviewed
Jan 24, 2023
elliette
reviewed
Jan 24, 2023
elliette
reviewed
Jan 24, 2023
elliette
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple requests
nshahan
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a few comments. Mostly questions about versions of deps and the SDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle SDK layout update:
3.0.0-134.0.dev
^4.0.0
^2.4.0
Towards: #1878