Skip to content

Prepare for dart 3.0 alpha changes: Handle SDK layout update #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2023

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Jan 24, 2023

Handle SDK layout update:

  • change min SDK constraint to 3.0.0-134.0.dev
  • update build_web_compilers to ^4.0.0
  • update build_runner to ^2.4.0
  • update SDK paths in code
  • remove CI testing on stable and add testing on main

Towards: #1878

- change min SDK constraint to 3.0.0-134.0.dev
- update build_web_compilers to ^4.0.0
- update build_runner to ^2.4.0
- update SDK paths in code
- remove CI testing on stable and add testing on main
@annagrin annagrin force-pushed the annagrin/rename-assets-only branch from 4e252f9 to 8922637 Compare January 24, 2023 19:24
Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple requests

Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few comments. Mostly questions about versions of deps and the SDK.

@annagrin
Copy link
Contributor Author

I addressed some comments, will addressed the rest (updating SDK constraints) in a separate PR. Thanks @nshahan and @elliette for the fast review!

@annagrin annagrin merged commit b3db2c9 into dart-lang:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants