-
Notifications
You must be signed in to change notification settings - Fork 82
Prepare for dart 3.0 alpha changes: generate assets #1887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for dart 3.0 alpha changes: generate assets #1887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the comments from @elliette.
I don't think the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few remaining comments. Thanks!
Ah, remembered those changes are being tracked here: #1845 |
Since I had to move webdev tests to sound null safety, it does not seem reasonable to run the CI analyzer task on the unsound one. So I just switched the task to run on the sound project. (It also fixed an analyzer test breaking). It seems like part of this change logically. If we would like to analyze or test other test fixtures on CI we can add it separately. |
Towards: #1878
Helps: #1818
Closes: #1591