Skip to content

Prepare for dart 3.0 alpha changes: generate assets #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 14, 2023

Conversation

annagrin
Copy link
Contributor

  • Prepare or Dart 3 alpha breaking changes:
    • Generate missing SDK assets for tests.
    • Enable null safe tests that use the generated assets.

Towards: #1878
Helps: #1818
Closes: #1591

@annagrin annagrin requested a review from nshahan January 13, 2023 03:41
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the comments from @elliette.

@elliette
Copy link
Contributor

I don't think the mono_pkg.yaml / mono repo changes should be part of this PR. It looks like we are missing mono_pkg.yaml files in some of our test fixtures, I think we should add those separately.

Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few remaining comments. Thanks!

@elliette
Copy link
Contributor

I don't think the mono_pkg.yaml / mono repo changes should be part of this PR. It looks like we are missing mono_pkg.yaml files in some of our test fixtures, I think we should add those separately.

Ah, remembered those changes are being tracked here: #1845

@annagrin
Copy link
Contributor Author

annagrin commented Jan 13, 2023

I don't think the mono_pkg.yaml / mono repo changes should be part of this PR. It looks like we are missing mono_pkg.yaml files in some of our test fixtures, I think we should add those separately.

Ah, remembered those changes are being tracked here: #1845

Since I had to move webdev tests to sound null safety, it does not seem reasonable to run the CI analyzer task on the unsound one. So I just switched the task to run on the sound project. (It also fixed an analyzer test breaking). It seems like part of this change logically. If we would like to analyze or test other test fixtures on CI we can add it separately.

@annagrin annagrin merged commit b1b4eff into dart-lang:master Jan 14, 2023
@annagrin annagrin mentioned this pull request Jan 24, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support running frontend server tests with sound null safety.
4 participants