Return error from expression evaluation if the evaluator is closed. #1884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
January 4, 2023 15:41
- Fix race condition on running two `createIsolate` calls simultaneously.
- Run `destroyIsolate` followed by `createIsolate` an atomic operation.
- Make debugger API that depend on isolate running wait for the start
of the app.
- Make debugger API throw if the isolate exits while the API is waiting.
- Fix exception on uninitialized `DwdsStats._devToolsStart` when using
an observatory uri to connect to the dwds VM service.
- Remove unnecessary async keywords from synchronoous debugger API.
Closes: ihttps://github.com/dart-lang/issues/1869
- Fix race condition on running two `createIsolate` calls simultaneously.
- Run `destroyIsolate` followed by `createIsolate` an atomic operation.
- Make debugger API that depend on isolate running wait for the start
of the app.
- Make debugger API throw if the isolate exits while the API is waiting.
- Fix exception on uninitialized `DwdsStats._devToolsStart` when using
an observatory uri to connect to the dwds VM service.
- Remove unnecessary async keywords from synchronoous debugger API.
Closes: ihttps://github.com/dart-lang/issues/1869
annagrin
commented
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return error from expression evaluation if the evaluator is closed.
MockModulesandFakeModulesHelps: #1869