Shard DWDS tests and fix CI test flakiness #1851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polina-c
reviewed
Dec 21, 2022
dwds/test/fixtures/utilities.dart
Outdated
| String get dwdsPath { | ||
| final pathParts = p.split(p.current); | ||
| // We expect all tests to be run from the webdev mono-repo: | ||
| assert(pathParts.contains('webdev')); |
There was a problem hiding this comment.
Consider putting 'webdev' to a constant
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #1845 (reduce time it takes for CI actions to run)
Addresses the task "DWDS tests should be sharded into groups (currently they take much longer than the other CI actions)" by breaking the DWDS tests into 4 groups, all of which are run on Linux / Windows, and with the stable and dev Dart SDKs:
Work towards #1842 (flakiness cause by file path issues):
utilitiesfile, so that they can be used by tests that aren't usingTestContext.