Add new getSourceReport parameter #1598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
reviewed
May 6, 2022
We don't actually support coverage through the vm implementation on web, Gary has some separate tool for that. So this is just to make sure adding the new parameter does not break the usage cases (it prevents us from updating vm_service internally) |
annagrin
changed the title
|
Can somebody review and approve this PR so we can land it and unblock dart-lang/sdk#48754 |
elliette
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
libraryFiltersparameter to the vm service implementation ofgetSourceReportto allow for updating vm service protocol to version8.3.0and dwds at the same time.Closes: #1585
Related: dart-lang/sdk#48754