Skip to content

Fix slow stepping into with deferred loaded modules #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 5, 2022
Merged

Fix slow stepping into with deferred loaded modules #1593

merged 4 commits into from
May 5, 2022

Conversation

annagrin
Copy link
Contributor

Fix issues discovered when using a combination of legacy module system, debug extension, and JIT modules:

  • Improve step-into times by not stepping into library loading code.
  • Fix incorrect skip lists due to unsorted locations.
  • Fix memory leak in extension debugger by removing stale script IDs.
  • Allow mapping JS locations to Dart locations matching other JS lines, to match the behavior of Chrome DevTools.

@annagrin annagrin requested review from nshahan and elliette April 28, 2022 20:28
@annagrin annagrin requested a review from nshahan May 5, 2022 17:36
@annagrin annagrin merged commit 16dc2c1 into dart-lang:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliette elliette elliette approved these changes

@nshahan nshahan Awaiting requested review from nshahan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annagrin @nshahan @elliette