Skip to content

Add columns to breakpoints #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 18, 2022

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Apr 5, 2022

This change allows setting breakpoints on dart lines that are compiled into the middle of longer JS lines. For example, in the following code Scaffold(...) is compiled into one JavaScript line, which did not let us set a breakpoint on // Breakpoint on this line line before:

Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar( // Breakpoint on this line
        title: Text(widget.title),
      ),
    ... 
   );
}

@annagrin annagrin force-pushed the annagrin/breakpoint-column branch from e29d39a to fa4e3eb Compare April 8, 2022 23:18
@annagrin annagrin requested review from nshahan and elliette April 8, 2022 23:20
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Anna! LGTM with a few comments.

@annagrin annagrin merged commit 0591fa8 into dart-lang:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants