-
Notifications
You must be signed in to change notification settings - Fork 82
Add columns to breakpoints #1560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
annagrin
merged 9 commits into
dart-lang:master
from
annagrin:annagrin/breakpoint-column
Apr 18, 2022
Merged
Add columns to breakpoints #1560
annagrin
merged 9 commits into
dart-lang:master
from
annagrin:annagrin/breakpoint-column
Apr 18, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e29d39a
to
fa4e3eb
Compare
nshahan
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Anna! LGTM with a few comments.
elliette
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows setting breakpoints on dart lines that are compiled into the middle of longer JS lines. For example, in the following code
Scaffold(...)
is compiled into one JavaScript line, which did not let us set a breakpoint on// Breakpoint on this line
line before: