-
Notifications
You must be signed in to change notification settings - Fork 82
Detect Flutter Web apps and embed inspector page for them #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Elliott! Is there a way to add tests for the new panel? I think we have extension tests somewhere.
<script src="panel.js"></script> | ||
</body> | ||
|
||
</html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a new line here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so - it is automatically removed by the formatter when I save the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a small comment
I have an open TODO to see if that's possible: https://github.com/dart-lang/webdev/blob/master/dwds/test/debug_extension_test.dart#L130-L132 WebDriver doesn't support interacting with Chrome DevTools, so with our current test infrastructure there is no way to test for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a comment.
dwds/debug_extension/web/devtools.js
Outdated
// If Flutter is not detected after 10 seconds, still | ||
// create the Dart Debugger panel: | ||
clearInterval(checkFlutterAppInterval); | ||
chrome.devtools.panels.create( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like for flutter the debugger panel is not created until the inspector one is available. Does it make sense to show the debugger panel always, and add the inspector panel when we can?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to that!
This is still just restricted to internal apps at the moment.