Update CONTRIBUTING doc for the Dart Debug Extension #1524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouma
reviewed
Feb 25, 2022
| > *At this point, you should manually verify that everything is working by following the steps in [Local Development](#local-development).* | ||
| 3. Open a PR to submit the version and build changes. | ||
| 4. Once submitted, pull the changes down to your local branch, and create a zip of the `debug_extension/web` directory (NOT `debug_extension/build/web`). | ||
| 5. Rename the zip `version_XX.XX.XX.zip` (eg, `version_1.24.0.zip`) and add it to the go/dart-debug-extension-zips folder |
There was a problem hiding this comment.
The idea is that if we need to "roll back" the extension (which is really just re-releasing an older version), we can do so easily. Obviously this would be possible if we just checked out a particular commit, but storing the zips makes it easier. We unfortunately still have to wait for the older version to get published.
There was a problem hiding this comment.
If I recall there isn't a supported rollback feature in the Chrome Webstore so this makes sense.
There was a problem hiding this comment.
Ok, great! Also added instructions on rollback to the doc
grouma
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more detailed instructions for building and releasing.