Enable expression evaluation by default in webdev #1488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshahan
approved these changes
Jan 18, 2022
Comment on lines
+54
to
+56
| dependency_overrides: | ||
| dwds: | ||
| path: ../dwds |
There was a problem hiding this comment.
Another double check that we want to submit with this dependency override?
There was a problem hiding this comment.
yes, we normally keep the override for dev versions of webdev, only changing it briefly to published version of dwds when preparing for publishing webdev. Will open a bug to invent a better story.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable expression evaluation by default in webdev.
Related: #715