Skip to content

reloadSources should wait until new sources are parsed before finishing/computing location information #2640

Open
@srujzs

Description

@srujzs

This explains some of the flakiness on the Windows bots when running hot_reload_breakpoints_test.dart in this PR: #2627. I was able to repro using my local Windows machine.

Specifically, when adding a breakpoint after a hot reload, we sometimes refer to the old JS script ID still instead of the new one because we didn't wait until we parsed the new scripts before fetching the JS script ID. _chromePathToRuntimeScriptId is the map in question:

chromePathToRuntimeScriptId[scriptPath] = e.script.scriptId;
. Used when adding breakpoints here:
return chromePathToRuntimeScriptId[serverPath];
.

I'll likely address this at the same time as #2628.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions