Remove renames where the type doesn't exist in package:web anymore

[maple135790]

This repository can not be run under Windows environment due to the path separator is not handled.

I have been working this, and successfully generating doms on Windows, but i have a problem about one test called 'dart fix' integration.

error message:

  error - lib\renames.dart:138:6 - Undefined class 'UnderlyingSource'. Try changing the name to the name of an existing class, or creating a class with the name 'UnderlyingSource'. - undefined_class

it seems like UnderlyingSource is not generated from the generator, and after seaching inside the this repo, i still cannot figure out what UnderlyingSource class is.

I am not sure if this is a Windows problem.

[srujzs]

I believe there are a couple of things happening here.

• We generate package:web definitions based on the Web IDL. The source for UnderlyingSource is in this file and where it's supposed to be used is here: https://github.com/w3c/webref/blob/f12a1e7e7ba5c2bea5094f96daf40d7838859aba/ed/idl/streams.idl#L8. Importantly, the type definition of the dictionary is never used by any API.
• Before v1, these renames were authored.
• With v1, we avoid generation definitions that never get used and/or are experimental. This is to reduce the number of breaking changes and avoid making internal migration harder.
• UnderlyingSource is now never generated and therefore this rename is invalid.

The fix on our end is to go through the renames and remove the ones which don't have a type in package:web anymore.

For you, I'd create your own dictionary type for UnderlyingSource using interop extension types. You can see some of the other extension types for dictionaries as a model.

I don't believe this has anything to do with Windows, so I'll edit the title.

[maple135790]

Thanks for your reply! I checked the use of UnderlyingSource in the repository and found that the issue can be easily fixed by removing the rename rule and related lines in rename.dart and rename.dart.expect.

After removing these lines, my local tests pass. Would you like me to submit a pull request with these changes?

Lastly, to keep this issue clear and simple, I will create another issue for the Windows path separator.

[srujzs]

Sure! Feel free to add a PR for this and I'll happily review.