Skip to content

Move dateStamp getter to utils.dart #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Apr 19, 2023

Addresses tech debt issue: #17

Keeps the dateStamp string getter in one location instead of having static methods defined in two separate classes (tech debt)

@eliasyishak eliasyishak marked this pull request as ready for review April 20, 2023 15:12
@eliasyishak eliasyishak requested a review from jcollins-g April 20, 2023 15:13
@eliasyishak eliasyishak added the type-tech-debt Improves codebase label Apr 20, 2023
@eliasyishak eliasyishak requested a review from bwilkerson April 20, 2023 18:50
@eliasyishak eliasyishak merged commit 5c9f45c into dart-lang:main Apr 20, 2023
@eliasyishak eliasyishak deleted the 17-move-datestamp-getters-to-utils branch April 20, 2023 18:54
dcharkes pushed a commit that referenced this pull request May 23, 2023
This also makes topologicalSort() and stronglyConnectedComponents()
iterative rather than recursive, so transitiveClosure() is able to
operate on very large graphs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants