Skip to content

Respect enableTagfilter when inlineOnly is passed #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srawlins merged 2 commits into from
Jul 22, 2026
Merged

Respect enableTagfilter when inlineOnly is passed #2471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c05ea2
Respect enableTagfilter when inlineOnly is passed
srawlins Jul 22, 2026
1372936
changelog
srawlins Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkgs/markdown/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
so that the created link can contain that content.
* For testing the package, adds matchers for `Element` and `Text` to more
directly test the output parsing.
* Fixes an issue such that `markdownToHtml`, when given `inlineOnly: true`,
now respects `enableTagfilter: true`.

## 7.3.1

Expand Down
7 changes: 6 additions & 1 deletion pkgs/markdown/lib/src/html_renderer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,12 @@ String markdownToHtml(
withDefaultInlineSyntaxes: withDefaultInlineSyntaxes,
);

if (inlineOnly) return renderToHtml(document.parseInline(markdown));
if (inlineOnly) {
return renderToHtml(
document.parseInline(markdown),
enableTagfilter: enableTagfilter,
);
}

final nodes = document.parse(markdown);

Expand Down
7 changes: 7 additions & 0 deletions pkgs/markdown/test/markdown_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,13 @@ nyan''',
''',
inlineOnly: true,
);
validateCore(
'filters disallowed html tags when enableTagfilter is true',
'foo <title> bar',
'foo &lt;title> bar',
inlineOnly: true,
enableTagfilter: true,
);
});

group('ExtensionSet', () {
Expand Down
Loading