-
Notifications
You must be signed in to change notification settings - Fork 58
[test_reflective_loader] Pass test locations to pkg:test
to improve IDE navigation
#2090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… IDE navigation This updates `pkg:test_reflective_loader` to the latest version of `pkg:test` and passes the locations of tests declarations through to `test()` calls. These locations are then used by `pkg:test` in the JSON reporter so that IDEs can navigate to the correct locations of these tests (rather than always to the `defineReflectiveTests()` call, because the real test declarations are not in the call stack at the point that `test()` is called). Fixes Dart-Code/Dart-Code#5480
Making this as WIP for now because there was a bug in the |
A new version of @scheglov are you the right person to review this (you were auto-assigned)? |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
@scheglov thanks! The failure was because the new I think someone will need to re-approve the bots to run with this change. |
lgtm; we can also bump to even more recent versions, up to and including the current stable if useful. |
Looks like the message from the first one wasn't the whole picture, it said:
And after asking for 3.2 it changed to:
But neither of these are actually accurate, because we're requiring test 1.26.1, and it turns out that needs 3.5. So, I've bumped it to 3.5 (3.8 would probably work, but if there's no need, it's probably nice to be compatible with more versions in case some haven't upgraded yet). Hopefully it'll work this time - someone will need to approve the bots again. Thanks! |
Removed the unnecessary import, should be good now 🙃 (someone will have to re-approve the bots - thanks!) |
+ update `rev_sdk_deps.dart` to work on Windows Revisions updated by `dart tools/rev_sdk_deps.dart`. tools (https://github.com/dart-lang/tools/compare/be0bd20..a433200c): a433200c Thu May 22 16:53:40 2025 +0100 Danny Tuppeny [test_reflective_loader] Pass test locations to `pkg:test` to improve IDE navigation (dart-lang/tools#2090) Change-Id: I9706a72ac850b3cd43bdeed671431cf836dcd860 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430501 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
@scheglov @devoncarew this landed in the SDK and I've confirmed it's all working as expected :) I don't know how many other projects use test_reflective_loader so publishing this is not a priority, but I don't know if not publishing it will cause any confusion (because it has a version in the changelog and the bot above marked it as ready-to-publish). I'll leave that to you to decide, since I'm not so familiar with the process. |
This updates
pkg:test_reflective_loader
to the latest version ofpkg:test
and passes the locations of tests declarations through totest()
calls.These locations are then used by
pkg:test
in the JSON reporter so that IDEs can navigate to the correct locations of these tests (rather than always to thedefineReflectiveTests()
call, because the real test declarations are not in the call stack at the point thattest()
is called).Fixes #2081
Fixes Dart-Code/Dart-Code#5480
fix.mp4