Skip to content

--disable-telemetry --> --disable-analytics #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Aug 15, 2023

To reduce confusion around the opt out commands, we will use the --disable-analytics flag that has already been implemented in dart

Flutter also has its own flutter config --no-analytics for opting out, but this PR has the update to use the new flag


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@eliasyishak eliasyishak marked this pull request as ready for review September 11, 2023 16:14
Copy link
Member

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are any people currently calling dart --disable-telemetry - not sure if we shipped a version w/ that flag or not? - it is possible to have a hidden alias for a flag, in order to support older renames.

@eliasyishak
Copy link
Contributor Author

eliasyishak commented Sep 11, 2023

@devoncarew the dart cli is already using the new flag from this PR dart --disable-analytics, it was an initial miscommunication where the flutter cli tool was using flutter --disable-telemetry

@eliasyishak eliasyishak merged commit fa01f9b into dart-lang:main Sep 11, 2023
@eliasyishak eliasyishak deleted the relabel-opt-out-command branch September 11, 2023 16:22
mosuem pushed a commit that referenced this pull request Aug 13, 2024
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.0 to 3.5.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@8f4b7f8...8e5e7e5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants