Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable avoid_dynamic_calls lint #2410

Merged
merged 13 commits into from
Oct 29, 2024
Merged

Enable avoid_dynamic_calls lint #2410

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7223169
Enable avoid_dynamic_calls lint
natebosch Oct 21, 2024
a459dce
Change to a more specific cast instead of using a dynamic call
natebosch Oct 21, 2024
7f2be62
Use a more specific function type for a `FeatureMatcher` generic.
natebosch Oct 21, 2024
077accf
format
natebosch Oct 21, 2024
8d0a7a8
Back as a cast
natebosch Oct 21, 2024
7b3d0de
Cleanup: Add a library directive for a test annotaiton
natebosch Oct 21, 2024
204d4c3
Use an intentional type widening to allow the cast
natebosch Oct 21, 2024
be5509d
Ignore a cast instead of loosening type
natebosch Oct 22, 2024
563608f
Remove a deprecated lint rule
natebosch Oct 22, 2024
cd007cc
Another pacakge_api_docs
natebosch Oct 22, 2024
22ab70f
Merge branch 'master' into matcher-dynamic
natebosch Oct 22, 2024
ab8f659
Typo in changelog
natebosch Oct 22, 2024
c5fbf31
Use FeatureMatcher for containsKey and containsValue
natebosch Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Back as a cast
  • Loading branch information
@natebosch
natebosch committed Oct 21, 2024
commit 8d0a7a850048c97e5673356c36499e9f04a0100b
3 changes: 1 addition & 2 deletions pkgs/matcher/lib/src/expect/throws_matcher.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,7 @@ class Throws extends AsyncMatcher {
}

try {
item as Object? Function();
var value = item();
var value = (item as Function)();
if (value is Future) {
return _matchFuture(value, 'returned a Future that emitted ');
}
Expand Down