Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple full paths on macos #2276

Merged
merged 22 commits into from
Sep 13, 2024
Merged

Add support for multiple full paths on macos #2276

merged 22 commits into from
Sep 13, 2024

Commits on Sep 3, 2024

  1. Add support for multiple full paths on macos 

    We cannot look up multiple basename commands in the system path and the
current `macOsExecutable` configuration may have existing uses in
`dart_test.yaml` files so it isn't safe to require full paths. Add a
separate `macOsAbsolutePaths` configuration to enable internal
definitions that check multiple full paths and execute the first one
that exists.

There is no support here for `dart_test.yaml`. Users that are
configuring an executable for macOS will continue to have support for
only a single value, even if they are specifying an absolute path.
    @natebosch
    natebosch committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    c77ed47 View commit details
    Browse the repository at this point in the history

  2. Changelog

    @natebosch
    natebosch committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    00d03e7 View commit details
    Browse the repository at this point in the history

  3. Normalize during construction 

    fixes merge behavior to correctly override.
    @natebosch
    natebosch committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    76ac322 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Use private field promotion 

    Co-authored-by: Jacob MacDonald <jakemac@google.com>
    @natebosch @jakemac53
    natebosch and jakemac53 authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d119016 View commit details
    Browse the repository at this point in the history

  2. Update pkgs/test/lib/src/runner/executable_settings.dart 

    Co-authored-by: Jacob MacDonald <jakemac@google.com>
    @natebosch @jakemac53
    natebosch and jakemac53 authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c01757d View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Merge branch 'master' into macos-full-paths

    @natebosch
    natebosch committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5039fcb View commit details
    Browse the repository at this point in the history

  2. Unskip firefox tests on mac

    @natebosch
    natebosch committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ec4029f View commit details
    Browse the repository at this point in the history

  3. Add firefox setup on osx

    @natebosch
    natebosch committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    dcced6f View commit details
    Browse the repository at this point in the history

  4. Remove references to removed mono repo validation job

    @natebosch
    natebosch committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    73e1432 View commit details
    Browse the repository at this point in the history

  5. Add some printf debugging

    @natebosch
    natebosch committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    03db40b View commit details
    Browse the repository at this point in the history

  6. Revert workflow changes

    @natebosch
    natebosch committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0061554 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Add a basename firefox as a fallback 

    Does Github Actions have it on the path?
    @natebosch
    natebosch committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6fc69b6 View commit details
    Browse the repository at this point in the history

  2. Desperate printf debugging - List all applications

    @natebosch
    natebosch committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    34f5df0 View commit details
    Browse the repository at this point in the history

  3. Maybe there is an applications directory in ~?

    @natebosch
    natebosch committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0d62e19 View commit details
    Browse the repository at this point in the history

  4. Try setup-firefox again with more log output

    @natebosch
    natebosch committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6d33661 View commit details
    Browse the repository at this point in the history

  5. Try more hacks in combination with setup-firefox

    @natebosch
    natebosch committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    aa4694a View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. read home directory instead of ~

    @natebosch
    natebosch committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2f8d38e View commit details
    Browse the repository at this point in the history

  2. ~ paths don't work

    @natebosch
    natebosch committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d217501 View commit details
    Browse the repository at this point in the history

  3. Drop debug logging

    @natebosch
    natebosch committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b1af826 View commit details
    Browse the repository at this point in the history

  4. check again if setup-dart is making the difference

    @natebosch
    natebosch committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    ef4e550 View commit details
    Browse the repository at this point in the history

  5. Fix double entry

    @natebosch
    natebosch committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    945d319 View commit details
    Browse the repository at this point in the history

  6. Restore skip 

    Cannot currently add setup firefox action

Tweak failure message.
    @natebosch
    natebosch committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d388e85 View commit details
    Browse the repository at this point in the history