Fixes for CombiningBuilder #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
grouma
reviewed
Jun 18, 2018
| contentBuffer.writeln(); | ||
|
|
||
| String part; | ||
| if (_outputPartOf) { |
There was a problem hiding this comment.
Discussed offline. These variable names are confusing and not indicative in what we are using them for.
There was a problem hiding this comment.
right...but is this PR okay otherwise?
There was a problem hiding this comment.
I was hoping you'd fix it in this one.
grouma
approved these changes
Jun 18, 2018
| contentBuffer.writeln(); | ||
|
|
||
| String part; | ||
| if (_outputPartOf) { |
There was a problem hiding this comment.
I was hoping you'd fix it in this one.
I'll do a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will land seperately