Skip to content

Conversation

@parlough
Copy link
Member

@parlough parlough commented Oct 24, 2025

Similar to the top navigation menu on widescreen layouts, keep track of the current active site section on the narrow-screen version of the sidenav.

This provides mobile users better insight into where on the site they are and will helps prepare for multiple sidenav support.


After:

Screenshot of the new buttons highlighting the Docs section

Before:

Screenshot of the old buttons with no highlighting

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Oct 24, 2025

Visit the preview URL for this PR (updated for commit 3148c3a):

https://dart-dev--pr6962-feat-active-site-section-sidenav-ogycrxjm.web.app

@parlough parlough requested a review from antfitch October 24, 2025 14:09
@parlough parlough marked this pull request as ready for review October 24, 2025 14:09
Copy link
Collaborator

@antfitch antfitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition of the icons, but I think we need to revisit what's in our top navigation pane. Let's sync to figure out what should go in that top menu moving forward.

@parlough
Copy link
Member Author

parlough commented Oct 27, 2025

@antfitch Thanks for taking a look!

I like the addition of the icons, but I think we need to revisit what's in our top navigation pane. Let's sync to figure out what should go in that top menu moving forward.

Do you mind if we land this in the current state? A next step (which I'll discuss as part of a design) will be getting rid of the top navigation in its current form. Landing this will help clear the way for making that possible alongside some other design fixes before then.

@antfitch
Copy link
Collaborator

Yes, we can land this in its current state, but before we do so, can you add Blog and Community into the drop down? That way nothing gets lost when we switch from horizontal to vertical top navigation.

Copy link
Collaborator

@antfitch antfitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!!! LGTM!

@antfitch antfitch merged commit 2d51159 into main Oct 27, 2025
11 checks passed
@parlough parlough deleted the feat/active-site-section-sidenav branch October 27, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants