Skip to content

Remove no-longer used sidenav include #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented Apr 21, 2023

This sidenav.html is no longer used by either site, with the sites using sidenav-level-1 and so on, as found in https://github.com/dart-lang/site-shared/tree/main/src/_includes

It being present make searching for sidenav related elements and classes harder, and it can be potentially confusing as changing it doesn't do anything.

@parlough parlough requested a review from domesticmouse April 21, 2023 22:31
Copy link
Collaborator

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 74292e2 into main Apr 25, 2023
@sfshaza2 sfshaza2 deleted the misc/remove-old-sidenav branch April 25, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants