Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support main (aka edge) builds #16

Merged
merged 4 commits into from
Jan 19, 2021
Merged

Support main (aka edge) builds #16

merged 4 commits into from
Jan 19, 2021

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Jan 19, 2021 •
edited
Loading

Fixes #4

@mit-mit mit-mit marked this pull request as ready for review January 19, 2021 19:42
This was referenced Jan 19, 2021
Merged
Closed
kevmoo
kevmoo approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth added a usage of this to the repo – just to sanity check?

@mit-mit
Copy link
Member Author

mit-mit commented Jan 19, 2021

Already did! See https://github.com/dart-lang/setup-dart/pull/16/files#diff-c6fe895eea1e566d8f6f9f7e5f045b702d9bff8e60bfaec2d412193bd802ab2aR18

@mit-mit
Copy link
Member Author

mit-mit commented Jan 19, 2021

And https://github.com/dart-lang/setup-dart/runs/1730214571?check_suite_focus=true

@kevmoo
Copy link
Member

kevmoo commented Jan 19, 2021

Land it! Tag it? Release it?

@mit-mit
Copy link
Member Author

mit-mit commented Jan 19, 2021

Just updated the readme, once that passes testing I'll merge it, and release as @v0.3

@mit-mit mit-mit merged commit b77f714 into main Jan 19, 2021
@mit-mit mit-mit deleted the main-channel branch January 19, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

@athomas athomas Awaiting requested review from athomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support installing "bleeding edge" SDKs
2 participants
@mit-mit @kevmoo