Flaky TSAN crash on vm/dart/regress47472_test

[alexmarkov]

/====================================================================================================\
| vm-tsan-mac-release-arm64:vm/dart/regress47472_test failed again (Timeout -> Crash, expected Pass) |
\====================================================================================================/

--- Command "vm" (took 01:03.000164s):
DART_CONFIGURATION=ReleaseTSANARM64 xcodebuild/ReleaseTSANARM64/dart -Dtest_runner.configuration=vm-tsan-mac-release-arm64 --ignore-unrecognized-flags --packages=/Volumes/Work/s/w/ir/.dart_tool/package_config.json /Volumes/Work/s/w/ir/runtime/tests/vm/dart/regress47472_test.dart

exit code:
-6

stderr:
===== CRASH =====
si_signo=Segmentation fault: 11(11), si_code=SEGV_ACCERR(2), si_addr=0xf2801527281ec870
version=3.10.0-edge (main) (Unknown timestamp) on "macos_arm64"
pid=33188, thread=16131, isolate_group=kernel-service(0x109c0d200), isolate=(nil)(0x0)
os=macos, arch=arm64, comp=no, sim=no
isolate_instructions=117698000, vm_instructions=100693560
fp=16fe52c30, sp=16fe52c00, pc=103ad61a0
  pc 0x0000000103ad61a0 fp 0x000000016fe52c30 __tsan::MemoryAccess(__tsan::ThreadState*, unsigned long, unsigned long, unsigned long, unsigned long)+0x88
  pc 0x0000000100c34890 fp 0x000000016fe52c90 dart::Scavenger::ShouldPerformIdleScavenge(long long)+0x84
  pc 0x0000000100c17958 fp 0x000000016fe52d50 dart::Heap::NotifyIdle(long long)+0x98
  pc 0x0000000100a18598 fp 0x000000016fe52d90 dart::IdleTimeHandler::NotifyIdleUsingDefaultDeadline()+0x80
  pc 0x0000000100a1892c fp 0x000000016fe52db0 dart::MutatorThreadPool::NotifyIdle()+0x48
  pc 0x0000000100a188e0 fp 0x000000016fe52e10 dart::MutatorThreadPool::OnEnterIdleLocked(dart::MutexLocker*, dart::ThreadPool::Worker*)+0x200
  pc 0x0000000100bdf310 fp 0x000000016fe52ed0 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*)+0xa0
  pc 0x0000000100bdf87c fp 0x000000016fe52f00 dart::ThreadPool::Worker::Main(unsigned long)+0xcc
  pc 0x0000000100b58288 fp 0x000000016fe52f70 dart::ThreadStart(void*)+0x128
  pc 0x0000000103a98da8 fp 0x000000016fe52fc0 __tsan_thread_start_func+0x8c
  pc 0x000000019b872f94 fp 0x000000016fe52fe0 _pthread_start+0x88
-- End of DumpStackTrace

--- Re-run this test:
python3 tools/test.py -n vm-tsan-mac-release-arm64 vm/dart/regress47472_test

full log

/cc @rmacnak-google

[rmacnak-google]

The test throws a million times. This is probably somehow throw unbalancing __tsan_func_entry/__tsan_func_ext.

[alexmarkov]

Another crash on the same test:

/=========================================================================================\
| vm-tsan-mac-release-arm64:vm/dart/regress47472_test failed again (Crash, expected Pass) |
\=========================================================================================/

--- Command "vm" (took 01.000924s):
DART_CONFIGURATION=ReleaseTSANARM64 xcodebuild/ReleaseTSANARM64/dart -Dtest_runner.configuration=vm-tsan-mac-release-arm64 --ignore-unrecognized-flags --packages=/Volumes/Work/s/w/ir/.dart_tool/package_config.json /Volumes/Work/s/w/ir/runtime/tests/vm/dart/regress47472_test.dart

exit code:
-6

stderr:
===== CRASH =====
si_signo=Segmentation fault: 11(11), si_code=SEGV_ACCERR(2), si_addr=0x126200000
version=3.10.0-edge (main) (Unknown timestamp) on "macos_arm64"
pid=9520, thread=11271, isolate_group=main(0x10dd00e00), isolate=main(0x10d703480)
os=macos, arch=arm64, comp=no, sim=no
isolate_instructions=104777560, vm_instructions=104777560
fp=16be798b0, sp=16be79890, pc=107b8aa58
  pc 0x0000000107b8aa58 fp 0x000000016be798b0 __tsan::ScopedInterceptor::ScopedInterceptor(__tsan::ThreadState*, char const*, unsigned long)+0xc4
  pc 0x0000000107b8a688 fp 0x000000016be79900 __tsan_memset+0x68
  pc 0x0000000104b41514 fp 0x000000016be79960 dart::SafepointMutexLocker::SafepointMutexLocker(dart::ThreadState*, dart::Mutex*)+0x5c
  pc 0x0000000104b417a4 fp 0x000000016be79990 dart::SafepointMutexLocker::SafepointMutexLocker(dart::ThreadState*, dart::Mutex*)+0x38
  pc 0x0000000104ca5fb4 fp 0x000000016be79ab0 dart::StackFrame::FindExceptionHandler(dart::Thread*, unsigned long*, bool*, bool*, bool*) const+0x1c8
  pc 0x0000000104af3928 fp 0x000000016be79bf0 dart::ExceptionHandlerFinder::Find()+0x1c4
  pc 0x0000000104af2248 fp 0x000000016be79d00 dart::ThrowExceptionHelper(dart::Thread*, dart::Instance const&, dart::Instance const&, bool, bool)+0x360
  pc 0x0000000104af1ee8 fp 0x000000016be79d20 dart::Exceptions::Throw(dart::Thread*, dart::Instance const&)+0x48
  pc 0x0000000104c6c4b0 fp 0x000000016be7a270 DRT_Throw+0x174
  pc 0x000000010e30352c fp 0x000000016be7a378 Unknown symbol
  pc 0x000000010e30d990 fp 0x000000016be7a3a8 Unknown symbol
  pc 0x0000000117a2f118 fp 0x000000016be7a430 Unknown symbol
  pc 0x0000000117a2eddc fp 0x000000016be7a458 Unknown symbol
  pc 0x0000000117a2ec7c fp 0x000000016be7a4b8 Unknown symbol
  pc 0x0000000117a2cb7c fp 0x000000016be7a4f8 Unknown symbol
  pc 0x0000000117a2c54c fp 0x000000016be7a560 Unknown symbol
  pc 0x0000000117a2a7b4 fp 0x000000016be7a5b8 Unknown symbol
  pc 0x000000010e303da4 fp 0x000000016be7a690 Unknown symbol
  pc 0x0000000104acd5e8 fp 0x000000016be7a720 dart::DartEntry::InvokeFunction(dart::Function const&, dart::Array const&, dart::Array const&)+0x2ec
  pc 0x0000000104ad00c0 fp 0x000000016be7a770 dart::DartLibraryCalls::HandleMessage(long long, dart::Instance const&)+0x1f0
../../runtime/vm/compiler/backend/linearscan.cc: 3028: error: unreachable code
Aborting reentrant request for stack trace.

--- Re-run this test:
python3 tools/test.py -n vm-tsan-mac-release-arm64 vm/dart/regress47472_test

full log