No analysis on `package:build` in `build` repo in VSCode

[davidmorgan]

I guess this is an issue with workspaces.

If I load the whole build repo in VSCode:

# ~/git/build from: https://github.com/dart-lang/build
code --remote ssh-remote+davidmorgan@<host> /usr/local/google/home/davidmorgan/git/build 

then everything works except in the folder ~/git/build/build, where there seem to be no analysis results reported.

For example if I write int x = '3'; at the top level in ~/git/build/lib/src/asset/reader.dart, nothing is reported.

I am guessing this might have something to do with both the workspace and package being called build. If I just rename the folder ~/git/build/build to ~/git/build/buildx, it immediately reports "A value of type 'String' can't be assigned to a variable of type 'int'.".

It also works without the rename if I open the package but not the workspace

code --remote ssh-remote+davidmorgan@<host> /usr/local/google/home/davidmorgan/git/build/build

In addition to that if I have two VSCode windows open, one at the workspace ~/git/build and one at the package ~/git/build/build, and make edits, and see analysis reported in the package window and not in the workspace window.

[bwilkerson]

@scheglov

[scheglov]

<workspace>/analysis_options.yaml excludes build.

include: package:dart_flutter_team_lints/analysis_options.yaml
analyzer:
<cut>
  exclude:
    # Prevents extra work during some e2e test runs.
    - "dart2js_test/**"
    # Common top level directories containing generated files in any package.
    - "build/**"
    - ".dart_tool/**"

[davidmorgan]

Oh. Whoops. Thanks!

It actually took me a minute to figure out what to do here ... the exclude is intended to cover

<workspace>/_test/build/**

but it also covers

<workspace>/build/**

which is unwanted.

The relative paths in the workspace analysis_options.yaml are being interpreted both relative to the workspace base and to every subfolder analysis_options.yaml that includes it. Which ... doesn't work for this case.

One random idea, it would be nice if rather than the subfolders including '../analysis_options.yaml' they could say something like 'workpace: ..', and have the workspace analysis options applied even if you open only the subfolder.

Anyway, that resolved my issue, thanks!