-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work ondevexp-pluginlegacy-area-analyzerUse area-devexp instead.Use area-devexp instead.type-enhancementA request for a change that isn't a bugA request for a change that isn't a bug
Description
The design we've roughly landed on is that // ignore:
and // ignore_for_file:
comments will supported for plugin-defined diagnostics (lints and warnings) via a plugin-namespaced name:
// ignore: foo.bar
This will direct the analyzer plugin tooling to ignore a report of the bar
diagnostic from the foo
plugin.
Notice the period (.
) delimiter. We discussed also the :
delimiter, but that looks confusing with ignore:
, especially since there does not need to be whitespace after ignore:
(e.g. // ignore:foo:bar
). We also considered /
, which I believe tslint uses, something like // ignore: foo/bar
. We decided that the period looks the most "darty," being reminiscent of property access, like "the bar diagnostic of the foo plugin."
FMorschel
Metadata
Metadata
Assignees
Labels
P2A bug or feature request we're likely to work onA bug or feature request we're likely to work ondevexp-pluginlegacy-area-analyzerUse area-devexp instead.Use area-devexp instead.type-enhancementA request for a change that isn't a bugA request for a change that isn't a bug