[CP] Fix DevTools failure to load in VS Code side panel

[elliette]

Commit(s) to merge

https://dart-review.googlesource.com/c/sdk/+/360281

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/360301

Issue Description

DevTools switched to compiling with unminified JS. This caused a type error preventing the VS Code DevTools side panel from loading: Dart-Code/Dart-Code#5049

What is the fix

We reverted to how we normally compile DevTools, with the default minified JS settings.

Why cherry-pick

Prevents Flutter VS Code side panel from loading, affecting all users of the side panel.

Risk

Low

Issue link(s)

Dart-Code/Dart-Code#5049

Extra Info

No response

[kenzieschmoll]

@elliette have you confirmed the PR you landed on main has the right version number for DevTools? According to the commit history, a commit snuck in before your commit that bumped the version to 2.35.0-dev.0: https://github.com/flutter/devtools/commits/master/

You can confirm by building the Dart SDK at your cl that missed the beta cut, and running dart devtools (where dart points to the SDK you just build)

[elliette]

Ah it almost certainly does not have the correct version number then. What's the best way to handle this?

[kenzieschmoll]

I think we will need to do a full cherry-pick release then.
https://github.com/flutter/devtools/blob/master/tool/RELEASE_INSTRUCTIONS.md#cherry-pick-releases

Since DevTools 2.34.1 has not yet been tagged and the DevTools master branch hasn't had any updates since your fix, here's what I would do:

1. open a PR on DevTools to change the version back to 2.34.1 (edit: done here Revert version to 2.34.1 flutter/devtools#7490)
2. once this PR is merged and the build has been uploaded to CIPD, create the Dart SDK cherry pick CL against the SDK beta branch using this hash.

[elliette]

I've updated this CP request to point to the correct CL, which contains the correct DevTools version.

[sigmundch]

➕ - LGTM to include this cherry-pick. It brings back devtools to use the same optimization level as it had in the past and addresses a visible regression.

cc @jacob314