Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in ImmutableList.toString #547

Closed
dgrove opened this issue Nov 21, 2011 · 3 comments
Closed

Error in ImmutableList.toString #547

dgrove opened this issue Nov 21, 2011 · 3 comments
Assignees

Comments

@dgrove
Copy link
Contributor

dgrove commented Nov 21, 2011

at r1707:

$ cat x.dart
final z = const<String> ['a', 'b'];

main() {
  print(z);
}

dgrove-macbookpro:frog dgrove$ ./frogsh x.dart

node.js:134
        throw e; // process.nextTick error, or 'error' event on first tick
        ^
TypeError: Array.prototype.toString is not generic
    at ImmutableList.toString (native)
    at print (evalmachine.<anonymous>:12:24)
    at main (evalmachine.<anonymous>:70:3)
    at evalmachine.<anonymous>:78:1
    at main (/Users/dgrove/repo/dart-bleeding/dart/frog/frogsh:22662:10)
    at Object.<anonymous> (/Users/dgrove/repo/dart-bleeding/dart/frog/frogsh:22990:1)
    at Module._compile (module.js:411:26)
    at Object..js (module.js:417:10)
    at Module.load (module.js:343:31)
    at Function._load (module.js:302:12)

dgrove-macbookpro:frog dgrove$ ../xcodebuild/Release_ia32/dart x.dart
ImmutableArray

@jmesserly
Copy link

I'll take a look. I think we aren't defining toString on ListFactory, and just so happen to be picking up the JS toString.


Added Started label.

@DartBot
Copy link

DartBot commented Nov 23, 2011

This comment was originally written by jimhug@google.com


Adding John as owner based on his comment that he started work <smile>.


Set owner to @jmesserly.

@jmesserly
Copy link

Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants