Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DDC] debugging metadata is incorrect for record types #54609

Closed
annagrin opened this issue Jan 12, 2024 · 2 comments
Closed

[DDC] debugging metadata is incorrect for record types #54609

annagrin opened this issue Jan 12, 2024 · 2 comments
Assignees
@annagrin
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. dev-compiler-eval web-dev-compiler web-eval evaluation support on the web

Comments

@annagrin
Copy link
Contributor

getObjectMetadata returns dart:_runtime library and RecordType class for a record type that is now an instance of _Type after change to the new type system.
@annagrin annagrin self-assigned this Jan 12, 2024
@annagrin annagrin added dev-compiler-eval web-eval evaluation support on the web web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. labels Jan 12, 2024
@annagrin annagrin mentioned this issue Jan 12, 2024
Closed
@nshahan
Copy link
Contributor

nshahan commented Jan 12, 2024

After talking yesterday I was thinking about this more and if we are calling getObjectMetadata on the value returned from a .runtimeType getter, then technically dart:_runtime library and RecordType were incorrect with the old type system too. That is the old internal representation and not what was returned from .runtimeType in the old type system. We probably should have always reported dart:core and Type, as the class along with RecordTypeKind.

@annagrin
Copy link
Contributor Author

We probably never run into that case due to runtimeType being a getter in the old system and not showing getters before in VSCode

@annagrin annagrin mentioned this issue Jan 22, 2024
Closed
copybara-service bot pushed a commit that referenced this issue Jan 29, 2024
[beta][ddc] Fix incorrect debugger information on record types.
437ab21 
Closes: #54609
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/345825
Cherry-pick-request: TBA
Change-Id: I42f0a22c99df5e15cc52aa2008c113ac94017080
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/348186
Commit-Queue: Kevin Chisholm <kevinjchisholm@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annagrin annagrin

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. dev-compiler-eval web-dev-compiler web-eval evaluation support on the web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nshahan @annagrin