Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out _isWhiteSpace in runtime/lib/string.dart #525

Closed
iposva-google opened this issue Nov 18, 2011 · 3 comments
Closed

Factor out _isWhiteSpace in runtime/lib/string.dart #525

iposva-google opened this issue Nov 18, 2011 · 3 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@iposva-google
Copy link
Contributor

There is no need to duplicate the same method in every String implementation.
@iposva-google
Copy link
Contributor Author

Added this to the Later milestone.
Removed Priority-Medium label.
Added Priority-Low label.

@iposva-google
Copy link
Contributor Author

Removed the owner.
Removed Type-Defect label.
Added Type-CodeHealth label.

@ghost
Copy link

ghost commented Jun 6, 2013

The code has been factored out into _StringBase._isOneByteWhitespace and _StringBase._isTwoByteWhitespace

Added Fixed label.

@iposva-google iposva-google added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P3 A lower priority bug or feature request area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. Fixed labels Jun 6, 2013
@iposva-google iposva-google added this to the Later milestone Jun 6, 2013
nex3 pushed a commit that referenced this issue Aug 31, 2016
instantiate generic tear-offs, fixes #525
7337734 
R=het@google.com

Review URL: https://codereview.chromium.org/1930323004 .
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iposva-google