Description
Commit(s) to merge
Target
beta
Prepared changelist for beta/stable
https://dart-review.googlesource.com/c/sdk/+/295386
Issue Description
Analysis server crash reporting, while long enabled internally, has been approved for external use. A change to enable it did not make the original beta cutoff.
What is the fix
The change, and proposed cherry-pick, allows crash reporting to be switched on. It connects directly to the same check used by unified_analytics to ensure that crash reporting is only enabled after a message is displayed on VSCode (the only IDE supported by analyzer analytics in our first release).
Why cherry-pick
This cherry-pick will not impact users directly, but the value of crash reporting in improving the analysis server long term is self-evident as we can not fix crashes we do not know about. Enabling crash reporting in 3.0 will get data from a much broader set of users, faster, than waiting for the next stable release. The earlier this can be cherry picked, the more visibility and impact for fixing user problems in the run-up to the final stable cut the analyzer team can have, as well.
While this will mean a large change in terms of lines of code executed by end users (all of the crash reporting), this code path is well-exercised internally and should pose little risk.
Risk
low
Issue link(s)
Extra Info
Because it does not seem possible to cherry-pick cherry-picks from third_party repositories, the change required in unified_analytics comes with a small amount of baggage in terms of other changes. These changes can be seen here, and appear to be trivial: https://github.com/dart-lang/tools/compare/0304fbb..2308c67.