Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search box match result presentation issues (was: dart editor - no way to navigate to a class) #489

Closed
DartBot opened this issue Nov 17, 2011 · 8 comments
Assignees

Comments

@DartBot
Copy link

DartBot commented Nov 17, 2011

This issue was originally filed by mattsh@google.com


I don't see any way in dart editor to type in a class name and jump to it. Is there a menu item for this?

@danrubel
Copy link

If you type in the search box (upper right) in the Dart Editor, does it find the class?
We were trying to keep things simple, but maybe we have a discoverability problem.

@DartBot
Copy link
Author

DartBot commented Nov 17, 2011

This comment was originally written by mattsh@google.com


Actually, when I do this, I see some 'I' and 'C' icons show up, but no names appear next to them, that is just white. So, perhaps that is actually the bug.
(btw - i like that that ctrl-3 hotkey is shown in the box, that is very handy)

@pq
Copy link
Member

pq commented Nov 17, 2011

Aha! I think I'm on to something here... Are you by chance on linux? If so, what distro, window manager and presentation 'theme' are you using? It sounds to me like the colors the search box is using to render search match results are not playing nice with your window manager settings. Specifically, I'm guessing our result color is the same as your manager's SWT list background... I bet I could quickly confirm this if you posted a screenshot.

Thanks!


Set owner to @pq.
Added Accepted label.
Changed the title to: "search box match result presentation issues (was: dart editor - no way to navigate to a class)".

@pq
Copy link
Member

pq commented Nov 17, 2011

OK, I answered my own question here. Witness the insanity when we use an inverted theme.


Attachment:
[Screen shot 2011-11-16 at 10.04.27 PM.png](https://storage.googleapis.com/google-code-attachments/dart/issue-489/comment-4/Screen shot 2011-11-16 at 10.04.27 PM.png) (14.71 KB)

@DartBot
Copy link
Author

DartBot commented Nov 17, 2011

This comment was originally written by mattsh@google.com


Yes, this is what I'm seeing (except i'll see the "I" and "C" icons on the left).

@pq
Copy link
Member

pq commented Dec 1, 2011

Finally got around to this one (a 2hr fix that took 2weeks to get to)... Anyhoo, this should be fixed as of https://code.google.com/p/dart/source/detail?r=2003.


Added Fixed label.

@DartBot
Copy link
Author

DartBot commented Dec 1, 2011

This comment was originally written by mattsh@google.com


Yes, just downloaded r2003 and it works. Looks quite nice now.


Added Verified label.

@pq
Copy link
Member

pq commented Dec 2, 2011

Fantastic. Thanks for verifying!

copybara-service bot pushed a commit that referenced this issue Nov 16, 2022
Changes:
```
> git log --format="%C(auto) %h %s" a70b93a..37951d1
 https://dart.googlesource.com/markdown.git/+/37951d1 Fix an ImageSyntax issue (#493)
 https://dart.googlesource.com/markdown.git/+/29196b7 Refactor CodeBlockSyntax (#488)
 https://dart.googlesource.com/markdown.git/+/32c52d6 benchmark: use Stopwatch over DateTime for benchmarking (#491)
 https://dart.googlesource.com/markdown.git/+/0a7a531 Refactor ATX headings (#486)
 https://dart.googlesource.com/markdown.git/+/2fab846 some cleanup (#489)
 https://dart.googlesource.com/markdown.git/+/816dd87 Refactor CodeSyntax (#487)
 https://dart.googlesource.com/markdown.git/+/a529e58 Fix HTML escape issues (#484)

```

Diff: https://dart.googlesource.com/markdown.git/+/a70b93a1a004cc1da04a3e3ea59821ef8391e0d6~..37951d151750acfae756b2e466f563c1c5119b3d/
Change-Id: I3f8419477df2280801be3cf9251e003f6c482984
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270224
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants