Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cider implementation for for super-initializer parameters #48070

Open
Tracked by #48055
devoncarew opened this issue Jan 4, 2022 · 6 comments
Open
Tracked by #48055

Cider implementation for for super-initializer parameters #48070

devoncarew opened this issue Jan 4, 2022 · 6 comments
Assignees
@keertip
Labels
area-google3 Tracking issues for internal work. Note that this area is not triaged.

Comments

@devoncarew
Copy link
Member

devoncarew commented Jan 4, 2022 •
edited
Loading

See #48055 for the main tracking issue.
@devoncarew devoncarew mentioned this issue Jan 4, 2022
Closed
23 tasks
@devoncarew devoncarew changed the title Cider implementation for for super-initializer parameters (todo:) Cider implementation for for super-initializer parameters Jan 4, 2022
@devoncarew
Copy link
Member Author

cc @keertip

@devoncarew devoncarew added the area-google3 Tracking issues for internal work. Note that this area is not triaged. label Jan 4, 2022
@stereotype441
Copy link
Member

Note: in our planning meeting on Dec 13, it was suggested that when the user hovers over an optional super parameter that inherits a default value from the corresponding parameter on the base class, the IDE should show the default value that's being inherited from the base class constructor. Doing so requires work in the analysis server, and possibly in some of the IDE integration logic.

@leafpetersen
Copy link
Member

FYI, the flag has been flipped so these can be used without a flag internally now.

@itsjustkevin
Copy link
Contributor

itsjustkevin commented May 5, 2022 •
edited
Loading

@leafpetersen per your comment, this issue seems like it can be closed. Feel free to reopen if I am incorrect.

@leafpetersen leafpetersen reopened this May 6, 2022
@leafpetersen
Copy link
Member

No, my comment was just to indicate that work on this can start.

@leafpetersen
Copy link
Member

@keertip do you have a status on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keertip keertip

Labels
area-google3 Tracking issues for internal work. Note that this area is not triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@stereotype441 @devoncarew @keertip @leafpetersen @itsjustkevin