-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Closed
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Description
A VM test has started failing after a change which affected stack traces.
The test has very specific regexps to match particular stack traces. Those stack traces no longer match, and I'm not in a position to guess which changes are needed.
If your test depends on recognizing specific structure which is not guaranteed to be stable against changes outside of your code, you need to have a script that can automatically update the expectations, and link to that script in the error message. Alternatively, you can modify the regexps to be more permissive and only check for the parts that you are in control of.
I'll mark the failures as accepted for now, so you can update the tests at your leisure. The affected tests are:
vm/dart_2/causal_stacks/async_throws_stack_no_causal_non_symbolic_testvm/dart_2/causal_stacks/async_throws_stack_no_causal_test
Metadata
Metadata
Assignees
Labels
area-vmUse area-vm for VM related issues, including code coverage, and the AOT and JIT backends.Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.