Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frog: implicit closure binding does the wrong thing for static methods #405

Closed
jmesserly opened this issue Nov 9, 2011 · 3 comments
Closed

Frog: implicit closure binding does the wrong thing for static methods #405

jmesserly opened this issue Nov 9, 2011 · 3 comments
Milestone
FrogEditor

Comments

@jmesserly
Copy link

class TestClass {
  static testMain() {
    var obj = new TestClass();
    print(obj.toString());
  }
}

// This gives a JS ReferenceError: "TestClass is not defined". I would've expected a no-op instead.
main() => TestClass.testMain; // intentionally missing parens to demonstrate the bug.
@jmesserly
Copy link
Author

Removed the owner.

@dgrove
Copy link
Contributor

dgrove commented Nov 29, 2011

Added this to the FrogEditor milestone.

@dgrove
Copy link
Contributor

dgrove commented Nov 30, 2011

as of r1908, frog no-ops correctly.

Added Fixed label.

@jmesserly jmesserly added this to the FrogEditor milestone Nov 30, 2011
nex3 pushed a commit that referenced this issue Aug 31, 2016
Merge pull request #405 from dart-lang/devoncarew-patch-2
55dedaf 
Update _operations.js
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
copybara-service bot pushed a commit that referenced this issue May 18, 2022
@devoncarew
Bump intl to 9145f308f1458f37630a1ffce3b7d3b471ebbc56
714db23 
Changes:
```
> git log --format="%C(auto) %h %s" 9669926..9145f30
 https://dart.googlesource.com/intl.git/+/9145f30 Bump actions/checkout from 2 to 3 (#462)
 https://dart.googlesource.com/intl.git/+/f545753 update the analysis_options.yaml file (#449)
 https://dart.googlesource.com/intl.git/+/fee2c2d Add a changelog entry for a recent feature (#406)
 https://dart.googlesource.com/intl.git/+/4e37662 GitHub Sync (#405)
 https://dart.googlesource.com/intl.git/+/0a14483 Bump dart-lang/setup-dart from 0.3 to 1 (#403)
 https://dart.googlesource.com/intl.git/+/f22f7b5 fix directive sorting
 https://dart.googlesource.com/intl.git/+/ed2fbe0 Add dependabot
 https://dart.googlesource.com/intl.git/+/2518923 Merge pull request #377 from dart-lang/franklinyow-patch-1
 https://dart.googlesource.com/intl.git/+/bee0456 Update LICENSE
 https://dart.googlesource.com/intl.git/+/9bb4bcc Migrating to dart:ffi in Dart 2.12.
 https://dart.googlesource.com/intl.git/+/532a1e3 Migrating to `dart:ffi` in Dart 2.12 and `package:ffi` 1.0.0.
 https://dart.googlesource.com/intl.git/+/458129d Replace git dependencies with published versions
 https://dart.googlesource.com/intl.git/+/5fd7a11 COPYBARA CHANGE FOR dart-archive/intl#358
 https://dart.googlesource.com/intl.git/+/2c8e014 Fix typo; see https://screenshot.googleplex.com/5afwL4iQtHeJKLC
 https://dart.googlesource.com/intl.git/+/33251e0 Prepare to publish for stable null safety (#362)
 https://dart.googlesource.com/intl.git/+/b3da438 Prep release for beta (#338)
 https://dart.googlesource.com/intl.git/+/48675cf Prepare a version of intl that supports the 2.12 sdk

```

Diff: https://dart.googlesource.com/intl.git/+/9669926609e7efc17dfd74fbb44ec719a7e573cc~..9145f308f1458f37630a1ffce3b7d3b471ebbc56/
Change-Id: Ic431da0e0785bd4ece86542fae30aad55f384f50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245222
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
FrogEditor
Development

No branches or pull requests
2 participants
@jmesserly @dgrove