Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using built-in identifiers as a name for a variable should cause a static warning #3228

Closed
DartBot opened this issue May 25, 2012 · 4 comments
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. closed-obsolete Closed as the reported issue is no longer relevant
Milestone

Comments

@DartBot
Copy link

DartBot commented May 25, 2012

This issue was originally filed by ms...@unipro.ru


Neither Dartc nor Dart2JS produces a static warning when a built-in identifier is used as the name of a variable, function or label.
Used Dartc and Dart2JS, r7976.
Corresponding tests in co19 repository:
from Language/10_Expressions/28_Identifier_Reference_A08_t01.dart
to Language/10_Expressions/28_Identifier_Reference_A08_t52.dart

@kasperl
Copy link

kasperl commented May 25, 2012

Splitting out the dart2js part in a separate bug.


Added Area-Analyzer, Triaged labels.

@kasperl
Copy link

kasperl commented May 25, 2012

The dart2js part is covered by issue #3230.

@bwilkerson
Copy link
Member

Added this to the M1 milestone.

@bwilkerson
Copy link
Member

There are no tests marked as failing because of this issue, nor are any of the specified tests marked as failing for any reason.


Added AssumedStale label.

@DartBot DartBot added Type-Defect area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. closed-obsolete Closed as the reported issue is no longer relevant labels Jun 25, 2012
@DartBot DartBot added this to the M1 milestone Jun 25, 2012
copybara-service bot pushed a commit that referenced this issue Oct 25, 2022
Revisions updated by `dart tools/rev_sdk_deps.dart`.

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/1d3565e..ea0ad27):
  ea0ad27  2022-10-25  Devon Carew  use lints 2.0.0; prep for publishing (#39)

dartdoc (https://github.com/dart-lang/dartdoc/compare/51464a3..8878245):
  8878245e  2022-10-24  dependabot[bot]  Bump actions/upload-artifact from 3.1.0 to 3.1.1 (#3228)
  85cfed81  2022-10-24  dependabot[bot]  Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (#3227)
  d152444e  2022-10-24  dependabot[bot]  Bump github/codeql-action from 2.1.26 to 2.1.28 (#3226)
  46f5f0d8  2022-10-24  Sam Rawlins  Switch all references from pub.dartlang.org to pub.dev (#3229)

glob (https://github.com/dart-lang/glob/compare/ee81279..073007c):
  073007c  2022-10-24  Kevin Moore  Merge branch 'v1_x'
  5d3d512  2022-10-24  Kevin Moore  drop author field from pubspec
  5345d2e  2022-10-24  Rob Becker  Add empty list_local_fs.dart for 1.2.1 (#64)

oauth2 (https://github.com/dart-lang/oauth2/compare/199ebf1..ee5c9b1):
  ee5c9b1  2022-10-24  dependabot[bot]  Bump actions/checkout from 3.0.2 to 3.1.0 (#135)
  4172ae5  2022-10-25  Devon Carew  use package:lints; rev pubspec version (#134)

Change-Id: I7fb7e92445645281a854cc188bdfda65679d1e7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265540
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 25, 2022
…4 revisions)

https://dart.googlesource.com/dartdoc/+log/51464a30fad5..8878245e0766

2022-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.1.0 to 3.1.1 (#3228)
2022-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.0.4 to 2.0.6 (#3227)
2022-10-25 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.1.26 to 2.1.28 (#3226)
2022-10-24 srawlins@google.com Switch all references from pub.dartlang.org to pub.dev (#3229)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC dart-ecosystem-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-ecosystem-gardener@grotations.appspotmail.com
Change-Id: I9f5b0f17075866c5416bf042013f7576d3c3308a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265365
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Development

No branches or pull requests

3 participants