Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples/proxy/MintMakerRpcTest fails on legium but test framework doesn't notice #2254

Closed
peter-ahe-google opened this issue Mar 22, 2012 · 4 comments
Closed

samples/proxy/MintMakerRpcTest fails on legium but test framework doesn't notice #2254

peter-ahe-google opened this issue Mar 22, 2012 · 4 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-obsolete Closed as the reported issue is no longer relevant

Comments

@peter-ahe-google
Copy link
Contributor

This is the console log from running MintMakerRpcTest on legium:

CONSOLE MESSAGE: line 7078: starting test
CONSOLE MESSAGE: line 7078: exit main
CONSOLE MESSAGE: line 9101: Uncaught TypeError: Cannot call method 'toSendPort$0' of undefined
Content-Type: text/plain
PASS

EOF

This is exactly the same as what happens when run with dart2js, but when running in drt, the failure is ignored.
@peter-ahe-google
Copy link
Contributor Author

The test is now passing, but is timing out. Still, the test framework does not handle crashed isolates.

@whesse
Copy link
Contributor

whesse commented Jun 14, 2012

Added this to the Later milestone.

@ricowind
Copy link
Contributor

Peter: is this still an issue?

@peter-ahe-google
Copy link
Contributor Author

Added AssumedStale label.

@peter-ahe-google peter-ahe-google added Type-Defect area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-obsolete Closed as the reported issue is no longer relevant labels Nov 15, 2013
@peter-ahe-google peter-ahe-google added this to the Later milestone Nov 15, 2013
dart-bot pushed a commit that referenced this issue Jan 16, 2020
@sigurdm
Bump pub revision in DEPS
be1ddc8 
New commits included in this revision:
```
$ git log --pretty=oneline 4d8ecbd409d773fec47da33b7e6c8db0b51487fd..429a06039d185149f387a65e3503b0693ce6d24e
429a06039d185149f387a65e3503b0693ce6d24e (HEAD -> master, origin/master, origin/HEAD) Parallel fetching of available versions (#2280)
6705b085b9bf4754a4c8002a070f436f115dc4d1 Retry on all SocketExceptions (#2254)
a1820273b9f3c7bb5a13d26cd14d30d5bab187ae Use a unqiue file name for the snapshot during testing. (#2303)
72686563e767f8a359e48a267a2c323953a6a0ef Include osx and windows testing on Travis (#2299)
a7a66821d13920b9b22cc394dfa55c679e971e40 Fail travis for lints and warnings (#2301)
25aa24c023453f064dad8f3cce1bbd55269d0efa Omit languageVersion when there is no SDK constraint (#2300)
82e60a3dcb3afe753563e7d304827fb650bc4833 Use LOCALAPPDATA for system cache on windows (#2297)
ceaa86f2c7eb35f044b4c202268a17361de68d13 Enforce and fix lints from package:pedantic (#2291)
6ce1606564352c305bd0f6d97704f0f7f6ebbca0 Use more collection literals for args (#2293)
be245e6baeebb71aaf3b3a260fcfbbb011a9a7e0 Rename some test utilities from Mock to Fake (#2294)
f7638ce85298df7d9e73d717dd4d81f499681720 Refactor Set.add following !Set.contains (#2295)
390022b24bc076cb934385936ac7904f045a75ba Filter out `null` from `getCachedPackages`. (#2292)
0eea0c4421ed0b83c8597b62dacf68b93de172b9 Fix existing hints and lints (#2290)
7cf2fe860a40517ccb65f5efdda9e4dc350142c3 promote strict deps failures to errors from warnings (#2289)
```

Change-Id: I62782b29e16092114940df00811bfdd20c8045fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131839
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
copybara-service bot pushed a commit that referenced this issue Oct 19, 2023
@devoncarew
[deps] rev ecosystem, lints, mockito, tools, vector_math, watcher, we…
a3c4232 
…bdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/dcbd2ee..4acfcaf):
  4acfcaf  2023-10-18  Devon Carew  depend on package:lints 3.0.0 (#187)

lints (https://github.com/dart-lang/lints/compare/90d350e..975c687):
  975c687  2023-10-17  Devon Carew  rev to 3.0.0; prep to publish (#160)

mockito (https://github.com/dart-lang/mockito/compare/47a5588..4edf86f):
  4edf86f  2023-10-18  Ilya Yanok  Change `!= null` to `is T` to handle "double nullable" case

tools (https://github.com/dart-lang/tools/compare/ddeccf6..15cc9c7):
  15cc9c7  2023-10-17  Elias Yishak  Add more info into the `AnalyticsException` (#181)

vector_math (https://github.com/google/vector_math.dart/compare/d54af8a..294896d):
  294896d  2023-10-18  Devon Carew  add a changelog entry for the most recent change (#290)
  2d6311e  2023-10-18  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.0 to 1.6.0 (#305)
  2c16283  2023-10-18  Kevin Moore  Allow latest pkg:build_web_compilers, bump min SDK to v3 (#299)
  cc8ca1c  2023-10-18  dependabot[bot]  Bump actions/checkout from 3.6.0 to 4.1.0 (#303)

watcher (https://github.com/dart-lang/watcher/compare/3998cdd..6ad58dc):
  6ad58dc  2023-10-19  Parker Lougheed  Migrate to dart_flutter_team_lints v2.1 (#153)

webdev (https://github.com/dart-lang/webdev/compare/8d48d5e..1bd434b):
  1bd434b6  2023-10-17  Elliott Brooks  Prepare DWDS for release to version 22.0.0 (#2254)
  c9e96b73  2023-10-16  Elliott Brooks  Run the Webdev tests daily with the Dart stable SDK (#2251)

Change-Id: I324913bfbdeb9d0d6afc38f8719cac5f5ffe9955
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/331204
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@whesse @ricowind @peter-ahe-google