Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large List's makes Scavenger slow #2153

Closed
andersjohnsen opened this issue Mar 14, 2012 · 2 comments
Closed

Large List's makes Scavenger slow #2153

andersjohnsen opened this issue Mar 14, 2012 · 2 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request

Comments

@andersjohnsen
Copy link

I have a small test-program that initializes and uses a large list:

import("dart:isolate");

foo() {
  var b = new ByteArray(1024 * 1024);
  void m() {
    b;
    var port = new ReceivePort();
    port.receive((message, reply) {
      port.close();
      foo();
    });
    port.toSendPort().call(null);
  }
  m();
}

main() => foo();

With --verbose-gc I can see that it takes Scavenger 361647us to run. If I change the list to ByteArray, it's running at only 1769us.

Thank you!,

  • Anders
@iposva-google
Copy link
Contributor

Not very surprising to me at the current non-tuned state: The scavenger has 1048576 at least more object pointers to traverse in the List case.


Set owner to @iposva-google.
Removed Priority-Medium label.
Added Priority-Low, Accepted labels.

@iposva-google
Copy link
Contributor

When using a List and the latest release Dart VM I get scavenges on the order of 300us.


Added Fixed label.

@andersjohnsen andersjohnsen added Type-Defect P3 A lower priority bug or feature request area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Aug 31, 2012
copybara-service bot pushed a commit that referenced this issue Jun 26, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/4757339..e04a6b3):
  e04a6b30  2023-06-23  Sam Rawlins  Remove grind_test; not important (#3453)

ecosystem (https://github.com/dart-lang/ecosystem/compare/a2dac18..b1056e6):
  b1056e6  2023-06-13  Nate Bosch  Allow prerelease suffix in CHANGELOG versions (#112)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/2149e5c..c75b0a7):
  c75b0a7  2023-06-23  Yii Chen  make LeakTrackingConfiguration to const (#83)

webdev (https://github.com/dart-lang/webdev/compare/6fe17fe..8360d50):
  8360d50f  2023-06-22  Elliott Brooks  Shard MV2 and MV3 extension tests (#2153)
  12e8aa2d  2023-06-22  Elliott Brooks  Reset Webdev to 3.0.6-wip (#2154)
  8ca3a891  2023-06-22  Elliott Brooks  Fix the Puppeteer tests for the Debug Extension (#2152)

Change-Id: I8f9ec79d99f375898b3ecd3330512fd39579f37b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/311462
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
copybara-service bot pushed a commit that referenced this issue Dec 11, 2023
…h, protobuf, sync_http, test, tools, web, webdev

Revisions updated by `dart tools/rev_sdk_deps.dart`.

ecosystem (https://github.com/dart-lang/ecosystem/compare/79a1bc5..ce707fb):
  ce707fb  2023-12-06  Moritz  Use Flutter in `health.yaml` (#206)

fixnum (https://github.com/dart-lang/fixnum/compare/6b0888c..3e08c0d):
  3e08c0d  2023-12-04  Kevin Moore  drop outdated lints (#123)

http_parser (https://github.com/dart-lang/http_parser/compare/1cf5b7c..224c1a9):
  224c1a9  2023-12-04  Kevin Moore  drop outdated lints (#82)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/a618a55..8644f8b):
  8644f8b  2023-12-11  Lucas.Xu  chore: bump leak_tracking_flutter_testing version to 1.0.12-wip (#192)
  cac195d  2023-12-11  Binni Goel  Fix. typos in leak_tracker (#189)
  9fd7932  2023-12-11  Lucas.Xu  fix: add missing on leak callback (#190)
  1ab3140  2023-12-08  Lucas.Xu  chore: refactor code style (#186)

mockito (https://github.com/dart-lang/mockito/compare/fb8a2b5..57a7c82):
  57a7c82  2023-12-06  Copybara-Service  Merge pull request #721 from Sese-Schneider:master
  c5de658  2023-12-06  Sese Schneider  Apply suggestions from code review
  1a652b8  2023-11-21  Sebastian Schneider  Use `posix` style for local imports

path (https://github.com/dart-lang/path/compare/18ec71f..115ea2a):
  115ea2a  2023-12-05  Devon Carew  rev the version of lints used; prep for publishing (#155)

protobuf (https://github.com/dart-lang/protobuf/compare/bb19774..20ec685):
  20ec685  2023-12-05  Ömer Sinan Ağacan  Small PbList improvements (#906)

sync_http (https://github.com/dart-lang/sync_http/compare/d8e9f3d..f96db95):
  f96db95  2023-12-05  Kevin Moore  Latest lints, require Dart 3.0, use mini-libraries (#42)

test (https://github.com/dart-lang/test/compare/9fffb48..43ff5bf):
  43ff5bf9  2023-12-11  Ömer Sinan Ağacan  Fix Dart2Wasm spelling (#2155)
  7d61eef9  2023-12-08  Derek Xu  Update frontend_server_client constraint to allow version 4.0.0 (#2153)
  001c5381  2023-12-07  Jacob MacDonald  fix precompiled vm tests loaded from a package: uri (#2152)
  fb3b5725  2023-12-05  Nate Bosch  Use package: URIs for imports when possible (#2148)
  03cc56ec  2023-12-05  Jacob MacDonald  mark flaky windows test as skipped (#2151)
  6e7e4fa8  2023-12-05  Jacob MacDonald  Add regression test for relative imports in tests under `lib` (#2147)
  84c366a7  2023-12-05  Jacob MacDonald  fix broken tests (#2149)
  e49ae54b  2023-12-05  Jacob MacDonald  Promote dart2wasm compiler support to the stable browser platform. (#2144)

tools (https://github.com/dart-lang/tools/compare/c63dcb5..ed81684):
  ed81684  2023-12-06  Elias Yishak  Fix consent message formatting (#215)
  c4d515a  2023-12-05  Elias Yishak  Enum + event added for `commandUsageValues` (#211)

web (https://github.com/dart-lang/web/compare/865aeaf..acf0beb):
  acf0beb  2023-12-07  Devon Carew  fixes to the return types of several Node helper extension methods (#121)
  9d7b33e  2023-12-06  Srujan Gaddam  Handle Dart SDK change to extension types (#116)
  0ae45ec  2023-12-05  Devon Carew  Update README.md (#117)
  34b3618  2023-12-05  Devon Carew  have web.dart export the helpers; deprecate helpers.dart (#115)

webdev (https://github.com/dart-lang/webdev/compare/63e09e5..8375cd6):
  8375cd66  2023-12-08  Elliott Brooks  Add popup for copying the app ID (#2299)

Change-Id: Ibf5f5eca74c56bf31d50bddabbe9da2a2e6fd716
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341021
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

2 participants